Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Customize additional event dispatching for video #2

Open
tungs opened this issue Jun 13, 2021 · 0 comments
Open

[FEATURE REQUEST] Customize additional event dispatching for video #2

tungs opened this issue Jun 13, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@tungs
Copy link
Owner

tungs commented Jun 13, 2021

Currently, video nodes still dispatches many events (canplay, etc), and timeweb only prevents some events (play and pause). Since video nodes that timeweb processes are always paused, and then seeked through to "play" them, this can create some unintended consequences. See tungs/timecut#55 for an example, where a canplay event is dispatched every single frame.

Video behavior may be further customizable by adding event listeners in addMediaNode and calling event.stopImmediatePropagation (or event.stopPropagation). That behavior is currently customized for play and pause events.

List of media events can be seen here. Of the list (abort, canplay, canplaythrough, durationchange, emptied, ended, error, loadeddata, loadedmetadata, loadstart, pause, play, playing, progress, ratechange, seeked, seeking, stalled, suspend, timeupdate, volumechange, waiting), only some of them are relevant. For each relevant one, it's likely that custom behavior needs to be defined and custom events need to be dispatched to restore intended behavior.

@tungs tungs added the enhancement New feature or request label Jun 13, 2021
@tungs tungs self-assigned this Jun 13, 2021
@tungs tungs changed the title Customize additional event dispatching for video [FEATURE REQUEST] Customize additional event dispatching for video Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant