Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this error more specific: "Error when contacting the Subsonic server. The requested data was not found." #234

Closed
arielelkin opened this issue Mar 30, 2016 · 1 comment

Comments

@arielelkin
Copy link

This error message should contain information about what caused it... I notice you could get it, for example, if the specified host doesn't exist, or if your credentials are invalid.

The cause of an error that's reported should be as clear as possible so that the user can recover from it.

@Hyzual
Copy link
Contributor

Hyzual commented Apr 2, 2016

The error message is actually composed of two parts: "Error when contacting the Subsonic server." which is prefixed for all kinds of network errors and the second part which depends on what is called. In your case it seems to be the error returned by the server you're using (Ampache, I'd guess), as I can't find "The requested data was not found" anywhere in our code.

In short, this error "The requested data was not found" is specific to Ampache, Subsonic (and its forks Madsonic and Music Cabinet) return a different error ("Wrong username or password.") when the credentials are invalid. I suspect it is being thrown because of some incompatibility between Jamstash and Ampache (see my response to #233).

That said I've just noticed that submitting an invalid url causes a javascript error and nothing is actually displayed to the user. I'll open another one for clarity.

@Hyzual Hyzual closed this as completed Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants