Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the R parsimony benchmarking and less horriblyify the code #19

Open
jeromekelleher opened this issue Sep 10, 2021 · 1 comment
Open
Assignees

Comments

@jeromekelleher
Copy link
Member

The R_implementations.R is my hacky attempt to get something to work in R. However, I'm substantially less confident that we're correctly measuring things there, since I'm a crap R programmer.

Some points to consider:

  • Is there any way to stop phangorm from finding the unique site patterns? Is what I'm doing correct? We're reporting the average per-site time, so we need to know how many sites are actually being processed.
  • Is the implementation really vectorised, written in C etc? It's a really strong point if we can say that (fairly obscure) C code embedded in the R interpreter is slower than JIT compiled Python, so it would be good if someone with stronger R skills could take a look.

@petrelharp, do I hear you volunteering for this 😉

@jeromekelleher
Copy link
Member Author

Might be worth looking at Castor (#14) while in there to see if it supports Sankoff/Hartigan parsimony?

@petrelharp petrelharp self-assigned this Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants