Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fasta_generate_regions.py #309

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update fasta_generate_regions.py #309

wants to merge 1 commit into from

Conversation

jdeligt
Copy link

@jdeligt jdeligt commented Aug 13, 2019

Minimal changes to make it python3 and 2 compatible, fixes some python pains for people installing through conda

@jdeligt
Update fasta_generate_regions.py
1392956 
Minimal changes to make it python3 and 2 compatible, fixes some python pains for people installing through conda
@jdeligt jdeligt mentioned this pull request Aug 13, 2019
Closed
@tseemann
Copy link
Owner

If you are using Conda, it should be using the one that comes with vcflib and is about to get a new release. But I will update the bundled one too.

@tseemann tseemann self-assigned this Aug 14, 2019
@tseemann tseemann self-requested a review August 14, 2019 00:10
@tseemann
Copy link
Owner

@jdeligt

  1. #!/usr/bin/python is still python 2. needs to be #!/usr/bin/env python3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseemann tseemann Awaiting requested review from tseemann

Assignees

@tseemann tseemann

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdeligt @tseemann