Get rid of extra indirections (WIP) #25
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting out to implement the ideas in #12.
Store a
Vector_
in the root node instead of anArray
ofVector_
s. This simplifies almost everythingand should make the code smaller. This seems especially
important for folds, which we generally want to inline. But
we get one extra indirection per vector until we actually
unlift everything.
Make
Vector_
a GADT. This lets us use the type system toenforce the height balance invariant. Ultimately, this is going
to have to look different, but I think it's not a bad first step.
Add a validity test to check the rest of the data structure
invariants.