refactor dockerfile, go modules with golang v1.14.2; closes #163 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffery#163" - removed dep-related comands and notes - added two Dockerfiles (works with Podman, Buildah too) - "prod": for clean build, with tests, runnng with non-root user, from scratch container - "dev": there is caching for golang deps, without tests, run as root, and result container can be not from scratch, for debug reasons. - docker-compose file: - added shared context-build block, DRY. - removed command name `jocko` in line `command: jocko broker...` because of we using the same ENTRYPOINT in docker file. - small fixes in module paths: - "github.com/hashicorp/consul/testutil/retry" -> "github.com/hashicorp/consul/sdk/testutil/retry" - update go.mod to the lastest version for all transitive deps (exepts github.com/mitchellh/go-testing-interface v1.4.0)
Downgrading github.com/mitchellh/go-testing-interface for supporting previous version Golang v1.13, not only v1.14 This version does not implement `Cleanup` and `Parallel` methods. ##[error]jocko/broker_test.go:446:27: cannot use t (type *"testing".T) as type "github.com/mitchellh/go-testing-interface".T in argument to NewTestServer: *"testing".T does not implement "github.com/mitchellh/go-testing-interface".T (missing Cleanup method)
|
@BOPOHA this looks good tho i don't think we should run the tests in the main dockerfile, maybe create a separate one called Dockerfile-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed dep-related comands and notes
added two Dockerfiles (works with Podman, Buildah too)
docker-compose file:
jockoin linecommand: jocko broker...because of we are using the same ENTRYPOINT in docker file.small fixes in module paths:
update go.mod to the lastest version for all transitive deps (exepts github.com/mitchellh/go-testing-interface v1.4.0)