Version 2.0.5 #70
Merged
Version 2.0.5 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that the main SDK instance (`tx`) can be set to `nil` using the `dispose()` method at any time, we need to ensure that the callback methods of the networking logic (`fetchTranslations`, `pushTranslations`, `foceCacheInvalidation`) will not capture the instance strongly, retaining it more than necessary. In order to address this, the internal `CDSPullRequest` class has been removed in favor of a private method in the `CDSHandler` class (`performFetch(...)`) that behaves similarly and ensures that the network callbacks are capturing a weak reference to the `CDSHandler` instance.
In device variation rules, the logic uses the iPad device name when the
user interface idiom is Pad,but that does not cover the corner case
where an iOS application targets a Vision device as a 'Designed for iPad'
application.
In order to on par with the logic implemented by Apple, the 'Designed
for iPad' applications on Vision devices, now use the correct device
name. The rest of the cases were also reviewed ('Designed for iPhone' /
'Designed for iPad' iOS apps running either on Mac or Vision devices).
More specifically:
* iPad applications running inside a Mac ("Designed for iPad") return
the "ipad" device name.
* iPhone applications running inside a Mac ("Designed for iPhone")
return the "iphone" device name.
* iPad applications running inside a Vision Pro ("Designed for iPad")
return the "applevision" device name.
* iPhone applications running inside a Vision Pro ("Designed for iPhone")
return the "iphone" device name.
Add documentation on the public methods that accept completion handlers that the handlers are called from background threads.
After the translations are fetched (pulled) from CDS, the cache is now updated in the main thread and only if the translations structure is not empty.
* Bumps `TXNative.version` to 2.0.5. * Updates CHANGELOG with the changes implemented for 2.0.5.
n1k0sv
approved these changes
Jul 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selfstrongly.fetchTranslationscall.