Version 2.0.1 #61
Merged
Version 2.0.1 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOS accesses the language tags using a hyphen (e.g. `en-GB`), whilst Transifex uses an underscore for the delimiter (e.g. `en_GB`). This discrepancy was causing an issue in the `BypassLocalizer` class logic, that is used to access the underlying bundled localized asset of the app as a final fall-back when the translated strings cannot be found. This fix replaces the underscore character (`_`) with a hyphen (`-`) in the provided `localeCode` of the `BypassLocalizer` constructor, to ensure that the underlying asset is always accessible by the logic.
* Bumps `TXNative.version` to 2.0.1. * Updates CHANGELOG with the changes implemented for 2.0.1.
n1k0sv
approved these changes
Sep 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundled source locale translations, in case the target translations was not
found, was trying to access the file by using the format that Transifex uses
(e.g.
en_US) instead of the one that iOS and Xcode use (e.g.en-US). Thelogic now normalizes the locale name to match the format that iOS accepts.