Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAM-572 Init investigation #308

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

nkarab
Copy link
Contributor

@nkarab nkarab commented Aug 30, 2023

Problem and/or solution

Up to this point, we've managed to incorporate context into YAML files using custom YAML tags, as shown below:

string: !context translation

However, the context is currently stored with an exclamation mark, which we'd like to eliminate.

How to test

Upload a YML i18n resource file that includes custom tags.

Reviewer checklist

Code:

  • Change is covered by unit-tests
  • Code is well documented, well styled and is following best practices
  • Performance issues have been taken under consideration
  • Errors and other edge-cases are handled properly

PR:

  • Problem and/or solution are well-explained
  • Commits have been squashed so that each one has a clear purpose
  • Commits have a proper commit message according to TEM

@nkarab nkarab force-pushed the CHAM-572-remove-exclamation-mark-from-yaml-context branch from 8ddfef5 to 8643af0 Compare August 31, 2023 12:50
@nkarab nkarab marked this pull request as ready for review August 31, 2023 12:55
@nkarab nkarab force-pushed the CHAM-572-remove-exclamation-mark-from-yaml-context branch 2 times, most recently from 27ed2f2 to e72c7e0 Compare September 1, 2023 07:10
@nkarab nkarab force-pushed the CHAM-572-remove-exclamation-mark-from-yaml-context branch from e72c7e0 to 67da127 Compare September 1, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants