Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI paths on Windows not working #31

Open
peterbrorsson opened this issue May 21, 2024 · 2 comments
Open

URI paths on Windows not working #31

peterbrorsson opened this issue May 21, 2024 · 2 comments
Labels
bug 🐛 Something isn't working good first issue Good for newcomers priority:medium Medium-priority tasks

Comments

@peterbrorsson
Copy link

It seems like a file uri reference like this:
file:///d:/sarif/demo.c
does not work.
This is the correct format according to https://datatracker.ietf.org/doc/html/rfc8089
and is also exemplified in the SARIF documentation (https://docs.oasis-open.org/sarif/sarif/v2.1.0/sarif-v2.1.0.html) (just 'find' C:)

It seems like it works in this format:
file://d:/sarif/demo.c // missing slash
and
file://d:\\sarif\\demo.c // missing slash and host path separator

@Vasco-jofra
Copy link
Collaborator

Thanks for the report! I haven't used SARIF Explorer on Windows, which is likely why this probably slipped through. I'll try to take a look at this soon. If you have a (non-confidential) SARIF file to reproduce the bug more easily, please share it. If not, I think I get there with your description as well.

@Vasco-jofra Vasco-jofra added bug 🐛 Something isn't working good first issue Good for newcomers priority:medium Medium-priority tasks labels May 28, 2024
@micaelbo
Copy link

I encounter the same problem. I get the message "Failed to open code region: SarifResultPathIsAbsolute: Result path is absolute but does not exist (/c:/wsl/sarif-test-960/Utilities.c). ..."

It seems the third "/" in "file:///" ends up in the path.

Example files attached.

sarif-test-960.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working good first issue Good for newcomers priority:medium Medium-priority tasks
Projects
None yet
Development

No branches or pull requests

3 participants