Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont treat Mercurial repos as an error #369

Open
jayvdb opened this issue Aug 22, 2024 · 1 comment
Open

Dont treat Mercurial repos as an error #369

jayvdb opened this issue Aug 22, 2024 · 1 comment

Comments

@jayvdb
Copy link

jayvdb commented Aug 22, 2024

In a similar vein as #279 , I see the following for https://crates.io/crates/oorandom

warning: failed to clone `https://hg.sr.ht/~icefox/oorandom`: [
    "fatal: repository 'https://hg.sr.ht/~icefox/oorandom/' not found\n",
]
...
oorandom (https://hg.sr.ht/~icefox/oorandom is uncloneable)

It is maintained, recently fixing the metadata - c.f. https://todo.sr.ht/~icefox/oorandom/8

While I can appreciate that there may not be much benefit in adding support for Mercurial repos, and a processing warning is useful, the crate should be "unmaintained" simply because it is using Mercurial.

A list of hg hosting platforms can be found at https://wiki.mercurial-scm.org/MercurialHosting . Some like https://hg.sr.ht/ and https://hg.mozilla.org/ and http://hg.code.sf.net/ include "hg." prefix which could be used to detect it.

However others dont have an easy way to detect e.g. https://crates.io/crates/bytes-cast

@smoelius
Copy link
Collaborator

Note to self: the report comes from here:

let repo_status = clone_repository(pkg, Purpose::Membership)?;

That is, to be considered maintained, a package must be a member of its named repository. And to determine whether that is the case, cargo-unmaintained must clone the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants