feat: expand onnx import #1813
feat: expand onnx import #1813
Conversation
JachymPutta
force-pushed
the
jp/expand_onnx_import
branch
3 times, most recently
from
10cda31
to
95c40fd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
- Coverage 86.44% 86.43% -0.02%
==========================================
Files 759 762 +3
Lines 87777 88099 +322
==========================================
+ Hits 75880 76147 +267
- Misses 11897 11952 +55 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good! Thank you for your contribution.
Minor. We should remove a case when we extract shape from Expand node attributes. Spec does not have it compared to other node types. Probably it was left from copying.
Once this is done, I believe we can merge it.
| } else { | ||
| node.attrs.get("shape").cloned().map(|v| v.into_i64s()) |
There was a problem hiding this comment.
This is not applicable for Expand since there is no attribute shape the spec: https://onnx.ai/onnx/operators/onnx__Expand.html. So we should remove it.
There was a problem hiding this comment.
Yes, you're right! I will get rid of it:)
JachymPutta
force-pushed
the
jp/expand_onnx_import
branch
from
95c40fd
to
c282d08
Compare
* feat: added expand to import
Changes
Include the expand operator to burn-import
Testing
Manual
cargo test expandRelated Issues
#1714