Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] tests: add tests for the comparison buttons #2029

Merged
merged 8 commits into from
Nov 28, 2024
Merged

[tests] tests: add tests for the comparison buttons #2029

merged 8 commits into from
Nov 28, 2024

Conversation

GresilleSiffle
Copy link
Collaborator

@GresilleSiffle GresilleSiffle commented Nov 14, 2024 •
edited
Loading

Description

The mobile comparison UI can now be forced in development environments by using a URL query parameter. The UI can now be tested in the e2e tests.

to-do

  • correctly name the tests and the environment var
  • tests:
    • a partial comparison
    • a full comparison
    • the navigation between the criteria
    • the buttons "next"

Checklist

  • I added the related issue(s) id in the related issues section (if any)
    • if not, delete the related issues section
  • I described my changes and my decisions in the PR description
  • I read the development guidelines of the CONTRIBUTING.md
  • The tests pass and have been updated if relevant
  • The code quality check pass

@GresilleSiffle GresilleSiffle self-assigned this Nov 14, 2024
@GresilleSiffle GresilleSiffle added Frontend Front-end code of Tournesol Frontend: tests Related to the tests of the front end labels Nov 14, 2024
@GresilleSiffle GresilleSiffle added this to the Mobile Friendliness milestone Nov 14, 2024
@GresilleSiffle GresilleSiffle marked this pull request as ready for review November 21, 2024 15:39
@GresilleSiffle GresilleSiffle merged commit d7accb4 into main Nov 28, 2024
6 checks passed
@GresilleSiffle GresilleSiffle deleted the tests-add_tests_for_the_comp_input_buttons branch November 28, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amatissart amatissart amatissart approved these changes

Assignees

@GresilleSiffle GresilleSiffle

Labels
Frontend: tests Related to the tests of the front end Frontend Front-end code of Tournesol
Projects
None yet
Milestone
Mobile Friendliness
Development

Successfully merging this pull request may close these issues.
2 participants
@GresilleSiffle @amatissart