[front] feat: add buttons to compare criteria #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GresilleSiffle
changed the title
… margin definition
amatissart
reviewed
Jun 6, 2024
frontend/src/index.css
Outdated
There was a problem hiding this comment.
On iOS, the "overscroll" rule has no effect. It's necessary to add
html {
overscroll-behavior-y: none;
}(if it has not undesirable effect on Android)
There was a problem hiding this comment.
Addressed by 2b6e534
amatissart
reviewed
Jun 6, 2024
| import CriterionButtons, { BUTTON_SCORE_MAX } from './CriterionButtons'; | ||
| import { useOrderedCriteria } from 'src/hooks/useOrderedCriteria'; | ||
|
|
||
| const SWIPE_TIMEOUT = 240; |
There was a problem hiding this comment.
I feel the animation is a bit slow and frustrating when looking for a specific criterion. Why not using the same value as in the EntitySelector?
Suggested change
| const SWIPE_TIMEOUT = 240; | |
| const SWIPE_TIMEOUT = 180; |
There was a problem hiding this comment.
Addressed by e3bed73
|
With a9655a1 I added an icon in the list of comparisons to indicate whenever a comparison has been made on a mobile device.
|
… should not trigger the slide animation
5 tasks
…h all criteria (#2024) * make 'next' buttons glow after has user has looped through all criteria * reduce padding of ContentHeader to gain some more vertical space * refactor: factorize behaviour of setHasLoopedThroughCriteria * fix: prevent accidental click on the criteria link * style: slightly faster glowing animation * ui: more understandable submit message on mobile --------- Co-authored-by: Gresille&Siffle <39056254+GresilleSiffle@users.noreply.github.com>
This reverts commit be54228.
amatissart
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issues #1940
Description
This PR adds a new comparison method for mobile devices: buttons.
Features
How the front end chooses to display buttons or sliders?
If the displayed comparison has been previously made with buttons, the buttons are displayed. If it has been rated by sliders, sliders are displayed.
If the displayed comparison is new, the button are displayed for devices not matching the media query
(pointer:fine), and the sliders are displayed for all other devices (See the pointer media feature).No conversion from buttons to sliders and from sliders to buttons is allowed for now.
Future improvements
to-do
front end - tutorial
front end - buttons
front end - comparison input
score_maxof the main criterion is 2score_maxof the main criterion is 10score_maxbetween != criteriafront end - comparison scores review
front end - comparison
front end - coherence
Preview
A "mobile" comparison displayed on desktop:
Checklist