[front] feat: add item in ShareMenu to share youtube link on mobile #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatissart
commented
Oct 3, 2023
Comment on lines
46
to
67
| if (youtubeLink && navigator.share) { | ||
| navigator.share({ url: youtubeLink }); | ||
| } |
There was a problem hiding this comment.
navigator.share is not available on all browsers (e.g on Firefox desktop, or on Chromium Linux). So we should use the clipboard as a fallback, or hide the menu item completely in that case.
amatissart
force-pushed
the
newpipe-jst
branch
from
d0b5db2
to
f4618e6
Compare
amatissart
changed the title
GresilleSiffle
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1800
Initiated by @jstainer-kleis
Description
This PR adds a button in the
ShareMenuto share link to current video on YouTube, especially useful to play the video in an alternavie app such as Newpipe.More over,
navigator.shareis also used by the other items to share the link to the current page, or the custom share message to another app on mobile.Checklist