[front] fix: in the comp. ui the glow effect is now triggered properly

tournesol-app · Nov 14, 2024 · c86d16a · c86d16a
1 parent 53a70e0
commit c86d16a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/frontend/src/features/comparisons/Comparison.tsx b/frontend/src/features/comparisons/Comparison.tsx
@@ -178,15 +178,22 @@ const Comparison = ({
         searchParams.delete(LEGACY_PARAMS[vidKey]);
         history.replace({ search: searchParams.toString() });
       }
+
       if (vidKey === 'vidA') {
         setSelectorA(newValue);
+
+        if (newValue.uid !== selectorA.uid) {
+          setHasLoopedThroughCriteria?.(false);
+        }
       } else if (vidKey === 'vidB') {
         setSelectorB(newValue);
-      }
 
-      setHasLoopedThroughCriteria?.(false);
+        if (newValue.uid !== selectorB.uid) {
+          setHasLoopedThroughCriteria?.(false);
+        }
+      }
     },
-    [history, setHasLoopedThroughCriteria]
+    [history, selectorA.uid, selectorB.uid, setHasLoopedThroughCriteria]
   );
 
   const onChangeA = useMemo(() => onChange('vidA'), [onChange]);

diff --git a/frontend/src/index.css b/frontend/src/index.css
@@ -37,7 +37,7 @@ code {
 
 /* Custom animation to draw attention on buttons */
 .glowing {
-  animation: glow 1.4s infinite alternate
+  animation: glow 1.4s infinite alternate;
 }
 
 @keyframes glow {