Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement full tests #145

Open
gkpty opened this issue Oct 3, 2020 · 2 comments
Open

Feature: Implement full tests #145

gkpty opened this issue Oct 3, 2020 · 2 comments
Assignees
Labels
Feature hacktoberfest An appropriate issue for Hacktoberfest test

Comments

@gkpty
Copy link
Collaborator

gkpty commented Oct 3, 2020

tests should be implemented for:

  • resourceExists methods
  • create Stack
  • update Stack
  • pull stack
  • push stack
  • delete stack

proposed solutions

  1. Localstack is a local (self-hosted) copy of AWS cloud that can be used to test AWS services. https://github.com/localstack/localstack.
    With localstack a stack can be created with torus, and then all of the resources can be tested using the resource exists method.
    This should be implemented locally and in the CI/CD service (travis).
  2. Test the resourceExists methods for an existing stack within our account (for example the stack for the torus.host site)
  3. Use aws-sdk-mock to mock the aws-sdk calls and assert for the method responses. https://www.npmjs.com/package/aws-sdk-mock
  4. A combination of these options
@gkpty gkpty added Feature hacktoberfest An appropriate issue for Hacktoberfest test labels Oct 3, 2020
@StephenTomlin
Copy link

StephenTomlin commented Oct 3, 2020

Could I take a crack at it?

@gkpty
Copy link
Collaborator Author

gkpty commented Oct 4, 2020

Hi @StephenTomlin Sure! I assigned the issue to you. Feel free to go about it however you like and im glad to discuss any options/hurdles you might run into. Also, if you prefer another testing framework feel free to switch out mocha.

P.S. i just merged a PR that fixes the test for the generateTemplate method and i added CI with travis CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature hacktoberfest An appropriate issue for Hacktoberfest test
Projects
None yet
Development

No branches or pull requests

2 participants