Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve type hints #1784

Merged
merged 1 commit into from
Nov 24, 2024
Merged

chore: improve type hints #1784

merged 1 commit into from
Nov 24, 2024

Conversation

waketzheng
Copy link
Contributor

  1. Remove 3 type:ignore comments
  2. Apply X|Y style which reduces import lines

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11976639446

Details

  • 20 of 22 (90.91%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 89.509%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/init.py 20 22 90.91%
Totals Coverage Status
Change from base Build 11963373385: -0.03%
Covered Lines: 6232
Relevant Lines: 6854
💛 - Coveralls

@waketzheng waketzheng merged commit 1e6089d into tortoise:develop Nov 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abondar abondar abondar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waketzheng @coveralls @abondar