New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve type hints #1779

Merged

henadzit merged 1 commit into tortoise:develop from waketzheng:improve-type-hints

Nov 21, 2024

Contributor

waketzheng commented Nov 20, 2024

Description

Improve type hints

Motivation and Context

How Has This Been Tested?

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added the changelog accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.


          refactor: improve type hints

6837d5b

coveralls commented Nov 20, 2024

Pull Request Test Coverage Report for Build 11931372986

Details

28 of 28 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 89.505%

Totals
Change from base Build 11923344025:	0.009%
Covered Lines:	6229
Relevant Lines:	6848

💛 - Coveralls

henadzit reviewed

View reviewed changes

Contributor

henadzit left a comment

A lot of nice improvements! I left a few minor comments.

tortoise/__init__.py Show resolved Hide resolved

tortoise/expressions.py Show resolved Hide resolved

henadzit approved these changes

View reviewed changes

henadzit merged commit 916d6cb into tortoise:develop

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet