Primary key field should not be nullable (#1778)

* Primary key field should not be nullable * chore: update changelog
tortoise · Nov 19, 2024 · 762fe37 · 762fe37
1 parent f5c2c64
commit 762fe37
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -12,7 +12,7 @@ Changelog
 ------
 Fixed
 ^^^^^
-- TODO
+- Primary key field should not be nullable (#1778)
 
 Added
 ^^^^^

diff --git a/tortoise/contrib/pydantic/creator.py b/tortoise/contrib/pydantic/creator.py
@@ -513,7 +513,9 @@ def _process_data_field(
         ptype = python_type
         if field.null:
             json_schema_extra["nullable"] = True
-        if field_name in self._optional or field.default is not None or field.null:
+        if not field.pk and (
+            field_name in self._optional or field.default is not None or field.null
+        ):
             ptype = Optional[ptype]
         if not (self._exclude_read_only and json_schema_extra.get("readOnly") is True):
             return annotation or ptype