Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async support #27

Open
tonybenoy opened this issue Aug 6, 2022 · 0 comments
Open

Add async support #27

tonybenoy opened this issue Aug 6, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@tonybenoy
Copy link
Owner

Requests was replaced with httpx in the early days so as to enable the wrapper to call the APIs asynchronously. Although httpx was added the async capabilities were never added/implemented due to a lack of time and me being lazy overall.
In order to implement the same I would have to either

  1. Add new methods i.e. async_
  2. Add a wrapper that would make the function awaitable if needed
  3. Add a new async class which would preferably inherit from CocApi and add async
    The main concern being that all methods are simply a wrapper around endpoints I really don't want to maintain twice the functions just to add async.
@tonybenoy tonybenoy self-assigned this Aug 6, 2022
@tonybenoy tonybenoy added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant