Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android compat #471

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Android compat #471

wants to merge 3 commits into from

Conversation

Trass3r
Copy link
Collaborator

@Trass3r Trass3r commented Oct 1, 2024

I guess I won't take this much further so I'll drop it here for reference and in case you want to pull some of it.

This removes stuff from Main as a first step and adds a main to AssetConverter so it can be used as a standalone tool too.

@Trass3r Trass3r marked this pull request as ready for review November 16, 2024 09:48
@Trass3r Trass3r requested a review from Copilot November 22, 2024 19:24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 161 out of 176 changed files in this pull request and generated no suggestions.

Files not reviewed (15)
  • src/toniarts/openkeeper/game/controller/creature/ICreatureController.java: Evaluated as low risk
  • src/toniarts/openkeeper/cinematics/Cinematic.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/component/MapTile.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/component/Navigation.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/controller/room/AbstractRoomController.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/controller/CreaturesController.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/controller/GameWorldController.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/controller/map/FlashTileControl.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/controller/IMapController.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/controller/entity/EntityController.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/controller/chicken/ChickenController.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/controller/room/CombatPitController.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/controller/MapController.java: Evaluated as low risk
  • src/toniarts/openkeeper/game/controller/room/DoubleQuadController.java: Evaluated as low risk
  • src/toniarts/openkeeper/common/EntityInstance.java: Evaluated as low risk
Comments skipped due to low confidence (1)

src/toniarts/openkeeper/Main.java:25

  • The initialization of the 'params' variable is incorrect. It should be 'new HashMap<>(args.length)'.
params = HashMap.newHashMap(args.length);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant