-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cached/Downloaded images (as in #200) are not used in the Toniebox tab of the WebUI #220
Comments
Please attach a log file with more details |
This is the log of a request to the Tonies tab:
(I changes some IDs and hashes ...)
Does this help? |
I assume this section was not handled when the cache functionality was added for the tonies. So this part needs to be implemented yet. |
@g3gg0 any comments? |
@g3gg0 added this |
Is it supposed to work already? |
what does the request to /api/tonieboxesJson give you back? i see a request to https://cdn.tonies.de/thumbnails/03-0009-i.png when i open it, however there is no box like that. |
I have a request to https://cdn.tonies.de/thumbnails/03-0009-i.png too, but it is blocked by ublock origin. There is another request to https://teddycloud.ip:8443/cache/a-lot-of-numbers.png that has a 200 OK status and contains the picture. But the picture is not shown on the website. (teddycloud.ip stand for the correct IP of my teddycloud instance and a-lot-of-numbers for the name of the picture) Here is the html: <div style="position: relative; width: 100%; height: 100%; overflow: hidden;">
<img src="https://cdn.tonies.de/thumbnails/03-0009-i.png" alt="" style="position: relative; filter: opacity(0); width: 100%; height: auto;">
<img src="/cache/a-lot-of-numbers.png" alt="" style="width: 100%; height: auto; position: absolute; top: 0px; left: 0px;">
</div> When the request to https://cdn.tonies.de/thumbnails/03-0009-i.png is blocked, the inner part of the |
Changing |
The one mentioned image is used as the default fallback image and is used to secure the size of the card. This is hard coded in a constants.tsx. Maybe I will replace that with a internally saved one. |
is it now working as expected? |
The entries from the json are handled as expected and only the previously hardcoded one was not cached (how should it ;) ) so with changing the hardcoded to the new custom one, everything is fine (and of course the custom local one does not need to be cached) |
(Be aware: this is not yet in the develop branch —> toniebox-reverse-engineering/teddycloud_web#187 ) |
@jensMF feel free to check it now. this change is now in develop! |
@henryk86 works very well now, thank you! And I really like the unknown box images :-) |
I updated to latest develop version today (2024-10-24 or 24th of October 2024).
I changed the settings to cache images and download images on first start. No image is shown in the Toniebox tab of the WebUI without allowing to load it from external sources.
The text was updated successfully, but these errors were encountered: