Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade golang.org/x/tools #48

Merged
merged 5 commits into from
Feb 19, 2024
Merged

deps: upgrade golang.org/x/tools #48

merged 5 commits into from
Feb 19, 2024

Conversation

tomarrell
Copy link
Owner

@tomarrell tomarrell commented Feb 19, 2024

Also updates the Go version used in tests.

Thanks to @rledisez.

Closes #46

@tomarrell tomarrell merged commit d45c49d into master Feb 19, 2024
1 check passed
@tomarrell tomarrell deleted the rledisez/master branch February 19, 2024 14:48
@ldez
Copy link

ldez commented Feb 19, 2024

@tomarrell can you downgrade your Go version inside go.mod to go1.21?

Since go1.21, the go version inside go.mod is a hard requirement for projects that depend on a module.

Inside Golangci-lint we should support go1.21.

This will not break your linter because the effective Go version is the version used during the compilation.

@tomarrell
Copy link
Owner Author

tomarrell commented Feb 19, 2024

@ldez yeah sure, will publish a new release shortly.

@tomarrell
Copy link
Owner Author

Apologies for the delay @ldez, the new release uses v1.21. Cheers!

https://github.com/tomarrell/wrapcheck/tree/v2.8.3

@ldez
Copy link

ldez commented Feb 20, 2024

Thank you @tomarrell ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrapcheck panic after upgrading to go 1.22
3 participants