Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel key will cancel all Effect Even with Different Store #32

Open
jeffersonsetiawan opened this issue Jul 14, 2022 · 1 comment
Open

Cancel key will cancel all Effect Even with Different Store #32

jeffersonsetiawan opened this issue Jul 14, 2022 · 1 comment

Comments

@jeffersonsetiawan
Copy link
Contributor

It's because the Effect cancellation is stored in the global internal var cancellationCancellables: [AnyHashable: Set<AnyDisposable>]

Discussed on this PR discussion

Tokopedia is using separate Store for every page/feature, so problem will happen in the future.
@jeffersonsetiawan jeffersonsetiawan added bug Something isn't working and removed bug Something isn't working labels Jul 14, 2022
@ivanbagaskara
Copy link
Contributor

will pick this up after finishing these two:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffersonsetiawan @ivanbagaskara