Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%vitals causes %spider to crash when checking unknown ship #216

Open
polwex opened this issue Aug 25, 2023 · 0 comments
Open

%vitals causes %spider to crash when checking unknown ship #216

polwex opened this issue Aug 25, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@polwex
Copy link

polwex commented Aug 25, 2023

When calling the %run-check poke on the %vitals app, the underlying thread fails causing a cascade of %spider and the whole Gall to crash.

Steps to reproduce the behavior:
Poke %vitals with an unknown ship.

Possible solution
Discussed with ~tinnus-napbus on Guild Hall and we found the bug in the scry run under ++get-qos in /garden/ted/vitals/connection-check. It crashes when the ship is unknown to ames.
A solution could be to change the scry for a .^((map ship ?(%alien %known)) %ax /=//=/peers), then do a has:by for the ships in question, and return some error message if %.n.

Happy to PR the fix myself.

Screenshot follows:
screenshot

@polwex polwex added the bug Something isn't working label Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant