You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When calling the %run-check poke on the %vitals app, the underlying thread fails causing a cascade of %spider and the whole Gall to crash.
Steps to reproduce the behavior:
Poke %vitals with an unknown ship.
Possible solution
Discussed with ~tinnus-napbus on Guild Hall and we found the bug in the scry run under ++get-qos in /garden/ted/vitals/connection-check. It crashes when the ship is unknown to ames.
A solution could be to change the scry for a .^((map ship ?(%alien %known)) %ax /=//=/peers), then do a has:by for the ships in question, and return some error message if %.n.
Happy to PR the fix myself.
Screenshot follows:
The text was updated successfully, but these errors were encountered:
When calling the
%run-check
poke on the%vitals
app, the underlying thread fails causing a cascade of%spider
and the whole Gall to crash.Steps to reproduce the behavior:
Poke %vitals with an unknown ship.
Possible solution
Discussed with
~tinnus-napbus
on Guild Hall and we found the bug in the scry run under++get-qos
in/garden/ted/vitals/connection-check
. It crashes when the ship is unknown to ames.A solution could be to change the scry for a
.^((map ship ?(%alien %known)) %ax /=//=/peers)
, then do ahas:by
for the ships in question, and return some error message if%.n
.Happy to PR the fix myself.
Screenshot follows:
The text was updated successfully, but these errors were encountered: