Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager): add loading message to files pane #42

Merged
merged 1 commit into from
Nov 23, 2020
Merged

feat(manager): add loading message to files pane #42

merged 1 commit into from
Nov 23, 2020

Conversation

etnguyen03
Copy link
Contributor

Adds a "loading" message to the files pane when it is loading.

image

See #41

@etnguyen03 etnguyen03 added the enhancement New feature or request label Nov 23, 2020
@etnguyen03 etnguyen03 requested a review from a team November 23, 2020 17:45
ghost
ghost approved these changes Nov 23, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage remained the same at 27.257% when pulling 9328c83 on etnguyen03:loading-files-pane into 31a4f33 on tjcsl:master.

theo-o
theo-o approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@theo-o theo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etnguyen03 etnguyen03 merged commit 2f76a82 into tjcsl:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theo-o theo-o theo-o approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etnguyen03 @coveralls @theo-o