Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect discriminator loss in GAIA notebook #12

Open
hanshengchiu opened this issue Mar 4, 2020 · 4 comments
Open

incorrect discriminator loss in GAIA notebook #12

hanshengchiu opened this issue Mar 4, 2020 · 4 comments

Comments

@hanshengchiu
Copy link

The following is discriminator's loss in the GAIA notebook. Shouldn't the d_xg_loss be negative?
disc_loss = d_xg_loss + d_x_loss - tf.clip_by_value(d_xi_loss, 0, d_x_loss)

@Abel1802
Copy link

Abel1802 commented Nov 17, 2020

I encountered the same problem when I reproduced the code.

@timsainb
Copy link
Owner

I should have mentioned that the notebook there was me experimenting with a variation of GAIA that I was trying out. I just added a line in the readme saying as much. But you're right. If someone wants to make a PR with the original algorithm for GAIA it would be much appreciated.

@Abel1802
Copy link

I should have mentioned that the notebook there was me experimenting with a variation of GAIA that I was trying out. I just added a line in the readme saying as much. But you're right. If someone wants to make a PR with the original algorithm for GAIA it would be much appreciated.

Thank you!

@timsainb
Copy link
Owner

I've got a cleaner tensorflow 1 implementation of GAIA in a private repo that I used for the 2D meshplot examples figure from the paper BTW. If anyone wants that code / access to that repo just ask. The repo is private just because its full of _Copy3.ipynb files with additional experiments that I never got around to making presentable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants