Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Don't need to encode tags when production #866

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leonliu06
Copy link

The tags with Chinese character would be double encoded when deploy in the way of static export. Then the server wold not find the correct route.

Copy link

vercel bot commented Mar 4, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @timlrx on Vercel.

@timlrx first needs to authorize it.

@timlrx
Copy link
Owner

timlrx commented Mar 31, 2024

Hmm I just noticed that there were some people who posted about this issue in #771 as well. What's the reason that encodeURI is needed in dev but not prod? And could you just if it works on a normal yarn build and yarn serve as well?

Would like to fix this issue properly.

this-is-spear added a commit to this-is-spear/blog that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants