Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expansion of port-bonding #5

Open
3 of 11 tasks
timbernat opened this issue Nov 17, 2023 · 0 comments
Open
3 of 11 tasks

Expansion of port-bonding #5

timbernat opened this issue Nov 17, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request planned-feature Changes or additons which are planned by the developer(s)

Comments

@timbernat
Copy link
Owner

timbernat commented Nov 17, 2023

Several refinements and additions planned for the rdutils.bonding module:

  • Considering making part of rdutils directly
  • Need to test and verify that saturated structures generate (under normal usage) valid RDKit Mols
  • Add support for labeling newly-created ports (as commented out here by decrease_bond_order uniquely via int_complement
  • Re-implement increase_bond_order to change bond in "one-shot" (rather than by iterating single-order upconversions). This would remove the need to relocate atom IDs by map number after each upconversion and would simplify sanitization
  • Canonicalize alternate implementation of _increase_bond_order backend method
  • Revisit implementations of dissolve_bond and saturate_ports
  • bonding.permutation :
    • add support for Cycle-based bond remap input (either via dict or directly via maths.cominbatorics.permutations.Cycle/Permutation) to reduce redundancy in current notation
    • add option to pass custom arrow delimiters for atom bond change (rather than just "----->" and "--x-->"
    • Have bond changes be logged, rather than printed
  • bonding.substitution : implement capping such that newly-inserted atoms in cap groups are appended to the list of atom ids, rather than mixed in (i.e. reimplement hydrogenate_mol_ports and saturate_ports to preserve initial atom order via Chem.rdmolops.RenumberAtoms)
@timbernat timbernat added enhancement New feature or request planned-feature Changes or additons which are planned by the developer(s) labels Nov 17, 2023
@timbernat timbernat self-assigned this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned-feature Changes or additons which are planned by the developer(s)
Projects
None yet
Development

No branches or pull requests

1 participant