Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic stacked-did (on new flask repository) #1265

Open
wants to merge 4 commits into
base: main-flask
Choose a base branch
from

Conversation

valerievossen
Copy link
Contributor

@valerievossen valerievossen commented Aug 19, 2024

(This is a new PR to the new master repository, the older one, #1236, I will close.
I checked the new style guidelines and fixed the links such that they work on the new website).

Hi @shrabasteebanerjee and @srosh2000,

This is the Stacked DiD topic, introducing the Weighted Stacked DiD method.
I kept the section about application in R small and highlighted the key steps, as the tutorial provided by the authors is really straightforward already and includes the function definitions.

Let me know what you think, thank you!

@srosh2000 srosh2000 self-requested a review August 22, 2024 16:35
Copy link

@srosh2000 srosh2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Valerie,

Great work! :D
I've added my suggestions.
As we discussed earlier, this alternative method to stacked DiD (Wing, C., Freedman, S. M., & Hollingsworth, A. (2024)) seems to be pretty new and is still a working paper. Would appreciate your take on this @kleintob: Should we keep this as is or should we maybe focus on the more established Stacked DiD method proposed by Cengiz et al. 2019? Feel free to add other suggestions you may have :D

content/topics/Analyze/causal-inference/did/stacked-did.md Outdated Show resolved Hide resolved
content/topics/Analyze/causal-inference/did/stacked-did.md Outdated Show resolved Hide resolved
content/topics/Analyze/causal-inference/did/stacked-did.md Outdated Show resolved Hide resolved
content/topics/Analyze/causal-inference/did/stacked-did.md Outdated Show resolved Hide resolved

Other approaches to aggregating ATT values include:

- *Population-weighted ATT*: Weights the group-time ATT by its share of the treated population (instead of the treated sample)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bit hard to give enough context on when/why to use the alternate weighting methods in a tip box alone. Maybe make it a subheading and give more info but m afraid the BB will get too long. To avoid info overload I'd simply point people to the relevant section in the paper for the different weighting approach. Its a whole discussion on its own ;)

Copy link
Contributor Author

@valerievossen valerievossen Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get your point! Do you agree that leaving it in a tipbox and referring to the paper section (as I did now), is good for leaving the discussion but highlighting that there's alternative methods?

content/topics/Analyze/causal-inference/did/stacked-did.md Outdated Show resolved Hide resolved
@valerievossen
Copy link
Contributor Author

@srosh2000 Thank you for the valuable feedback!! I implemented your comments

@alexandervossen
Copy link
Contributor

@srosh2000 can I merge this? Thanks!A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants