Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecurityPkg: Improve formatting of msg when GetVariable fails #6477

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bexcran
Copy link
Contributor

@bexcran bexcran commented Nov 27, 2024

Description

Improve the formatting of the error message when GetVariable fails: start the message with an upper-case character, and close the quotes around the variable name.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Verified the error message was formatted better after the change.

Integration Instructions

N/A

Improve the formatting of the error message when GetVariable
fails: start the message with an upper-case character, and close the
quotes around the variable name.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
@bexcran bexcran force-pushed the secure-boot-provision-error-msg-formatting branch from a9e8054 to 90ad6ee Compare November 27, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant