RedfishPkg/RedfishPlatformConfigDxe: check attribute max. and min. value #6452
Conversation
tianocore-assign-reviewers
bot
requested review from
changab and
igorkulchytskyy
- For integer attribute, check and see if its value is between maximum and minimum value defined by HII question. - For string attribute, check and see if its string length is between maximum string length and minimum string length defined by HII question. Signed-off-by: Nickle Wang <nicklew@nvidia.com>
nicklela
force-pushed
the
redfish-value-range-check
branch
from
370df61
to
d3660a3
Compare
|
@igorkulchytskyy could you help me to review this change if you have chance? Thanks! |
@nicklela I asked a question about a week ago to clarify one thing. Other than this question, everything looks good for me. Could you please answer my question, so I can finish my review process. |
Hi Igor, it looks like I cannot see your question on GitHub again. Below is what I see on this page. Can you post your question again? Thanks!
Or you are talking about the question in email discussion? If yes, this is separated new review and this is to fix a bug in RedfishPkg. For the question in email, I still need time to finish my diagram of explaining the Redfish task service. |
| DEBUG ((DEBUG_ERROR, "%a: string length: %u is smaller than minimum string length: %u\n", __func__, StrLength, TargetStatement->StatementData.StrMinSize)); | ||
| return EFI_ACCESS_DENIED; | ||
| } | ||
|
|
||
| // |
There was a problem hiding this comment.
Nickle,
what if some statement does not have StrMaxSize set?
Will we have it as 0 and the condition fail?
Or in this case the condition should not be verified?
Description
For integer attribute, check and see if its value is between maximum and minimum value defined by HII question.
For string attribute, check and see if its string length is between maximum string length and minimum string length defined by HII question.
Breaking change?
Impacts security?
Includes tests?
How This Was Tested
Integration Instructions
N/A