Upld enhacement #6451
Open
Upld enhacement #6451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
benjamindoron,
gguo11837463,
jameslu8,
LinusvPelt and
Sean-StarLabs
3 tasks
LinusvPelt
reviewed
Nov 20, 2024
Current implementation only supports serial port sub-node under PCI root bridge node. This enhancement support serial port node regardless it is under root node or PCI root bridge node using a single FDT passing function. Signed-off-by: Guo Dong <guo.dong@intel.com>
If there is no relocation in the payload it would build failure. This will fix the build failure. Signed-off-by: Guo Dong <guo.dong@intel.com>
gdong1
force-pushed
the
upld_enhacement
branch
from
a5dc751
to
3d3a0a8
Compare
LinusvPelt
reviewed
Nov 20, 2024
| IN VOID *Fdt, | ||
| IN INT32 SubNode, | ||
| IN UINT32 AddressCells, | ||
| IN UINT32 SizeCells | ||
| ) |
There was a problem hiding this comment.
It seems input SizeCells wasn't used in this function.
Can we remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an enhancement for universal payload serial port FDT node.
<Include a description of the change and why this change was made.>
Current impl doesn't support serial port node under root node, only support it under PCI root bridge node. This PR fixed it.
<For each item, place an "x" in between
[and]if true. Example:[x](you can also check items in GitHub UI)><Create the PR as a Draft PR if it is only created to run CI checks.>
<Delete lines in <> tags before creating the PR.>
How This Was Tested
It was tested with Slim Bootloader on QEMU platform.
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>