Support for <picture> element #17
Comments
frsinn
added a commit
to frsinn/image-focus
that referenced
this issue
Sep 12, 2023
This is a more customizable than the one suggested in third774#17. It should also be a non-breaking change as `container` is optional. If a user did not pass `container` as option, we fall back to the current behaviour.
frsinn
added a commit
to frsinn/image-focus
that referenced
this issue
Sep 12, 2023
This is a more customizable than the one suggested in third774#17. It should also be a non-breaking change as `container` is optional. If a user did not pass `container` as option, we fall back to the current behaviour.
|
Hi @brianjacobs-natgeo, I proposed a change to the library that follows your proposed solution using options, see #50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, great library!
In using this I've wanted to use it for images within the
<picture>elementBecause image-focus looks for the
parentElementof an image as the container, styling can get messed up if the parent is a<picture>. This line has worked as a fix for me, bypassing the parent<picture>Alternatively, allow me to explicitly set a container option that would override the default parentElement
The text was updated successfully, but these errors were encountered: