Changed logger.py to comply with MS Flow HTTP code #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As Microsoft has started to deprecate the "Incoming Webhook" functionality in favor of their workflow features, the standard HTTP response code is now 202, instead of just 200.
Change: I amended the response code checker just a hair to include both 200 and 202 for backwards compatibility on line 310 of logger.py.
Reference about 202 response code: https://community.dynamics.com/blogs/post/?postid=d914a6af-bef3-417f-a02b-0571610e3a05
Types of changes
What types of changes does your code introduce to this repository?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.pre-commit
in the repo)Further comments
I did not run any pre-commit checks, as I'm unable to get a proper development environment spun up right this moment to test, but I did test it in a production canary by modifying the logger.py and it resolved the error popping up in the logs.
Initial error:
After updating logger.py:
If absolutely necessary, I'll see if I can find some time to spin up a GitHub Workspace and run the pre-commit hooks.
Thank you!