Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve static files over express server #161

Closed
faisalsiddique4400 opened this issue Mar 6, 2024 · 2 comments
Closed

Serve static files over express server #161

faisalsiddique4400 opened this issue Mar 6, 2024 · 2 comments

Comments

@faisalsiddique4400
Copy link

Is your feature request related to a problem? Please describe.
Soul currently lacks support for serving static media files. It is essential to implement a configuration option in Soul to enable the serving of static files.

Describe the solution you'd like
A customizable feature, similar to extensions, should be provided, allowing users to specify a folder path for serving its contents statically.

Additional context
This wrapper is highly compatible with react-admin. If react-admin facilitates handling the upload of media files (such as images) and storing their URLs in the database, Soul should also provide a mechanism to serve these media files. This issue aims to bring attention to the absence of this particular feature in Soul.

@IanMayo
Copy link
Collaborator

IanMayo commented Mar 6, 2024

Hello @faisalsiddique4400 , I'm pretty sure my team has implemented a working instance of this using _extensions, without requiring any changes to soul-cli. We're serving a compiled react-admin app as static html content from a soul-cli instance.

If the compiled app is loaded into the dist sub-folder of a Soul-cli instance, it can be server from the root url using a Soul extension like this:
image

@thevahidal
Copy link
Owner

Hi @faisalsiddique4400,
@AbegaM is working on a new PR about how to serve static files over Soul. Check out #208 for instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants