Switch to sync.RWMutex #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow atomic reloads for passwd and group files this libraries uses mutexes to prevent lookups during reloads. In the current form this also means that concurrent lookups are not possible. This change replaces sync.Mutex with sync.RWMutex which allows concurrent read access. Signed-off-by: Christian Pointner <equinox@spreadspace.org>
tg123
approved these changes
Nov 10, 2023
codeboten
referenced
this pull request
in open-telemetry/opentelemetry-collector-contrib
Dec 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/tg123/go-htpasswd](https://togithub.com/tg123/go-htpasswd) | `v1.2.1` -> `v1.2.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tg123/go-htpasswd (github.com/tg123/go-htpasswd)</summary> ### [`v1.2.2`](https://togithub.com/tg123/go-htpasswd/releases/tag/v1.2.2) [Compare Source](https://togithub.com/tg123/go-htpasswd/compare/v1.2.1...v1.2.2) #### What's Changed - Switch to sync.RWMutex by [@​equinox0815](https://togithub.com/equinox0815) in [https://github.com/tg123/go-htpasswd/pull/10](https://togithub.com/tg123/go-htpasswd/pull/10) - Bump golang.org/x/crypto from 0.6.0 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/tg123/go-htpasswd/pull/11](https://togithub.com/tg123/go-htpasswd/pull/11) #### New Contributors - [@​equinox0815](https://togithub.com/equinox0815) made their first contribution in [https://github.com/tg123/go-htpasswd/pull/10](https://togithub.com/tg123/go-htpasswd/pull/10) - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/tg123/go-htpasswd/pull/11](https://togithub.com/tg123/go-htpasswd/pull/11) **Full Changelog**: tg123/go-htpasswd@v1.2.1...v1.2.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuMTAzLjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com>
cparkins
referenced
this pull request
in AmadeusITGroup/opentelemetry-collector-contrib
Jan 10, 2024
](https://renovatebot.com){kind=link}
…30078) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/tg123/go-htpasswd](https://togithub.com/tg123/go-htpasswd) | `v1.2.1` -> `v1.2.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tg123/go-htpasswd (github.com/tg123/go-htpasswd)</summary> ### [`v1.2.2`](https://togithub.com/tg123/go-htpasswd/releases/tag/v1.2.2) [Compare Source](https://togithub.com/tg123/go-htpasswd/compare/v1.2.1...v1.2.2) #### What's Changed - Switch to sync.RWMutex by [@&open-telemetry#8203;equinox0815](https://togithub.com/equinox0815) in [https://github.com/tg123/go-htpasswd/pull/10](https://togithub.com/tg123/go-htpasswd/pull/10) - Bump golang.org/x/crypto from 0.6.0 to 0.17.0 by [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/tg123/go-htpasswd/pull/11](https://togithub.com/tg123/go-htpasswd/pull/11) #### New Contributors - [@&open-telemetry#8203;equinox0815](https://togithub.com/equinox0815) made their first contribution in [https://github.com/tg123/go-htpasswd/pull/10](https://togithub.com/tg123/go-htpasswd/pull/10) - [@&open-telemetry#8203;dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/tg123/go-htpasswd/pull/11](https://togithub.com/tg123/go-htpasswd/pull/11) **Full Changelog**: tg123/go-htpasswd@v1.2.1...v1.2.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuMTAzLjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Alex Boten <aboten@lightstep.com>
This was referenced Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow atomic reloads for passwd and group files this libraries uses mutexes to prevent lookups during reloads. In the current form this also means that concurrent lookups are not possible. This change replaces sync.Mutex with sync.RWMutex which allows concurrent read access.