Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions need to be set on AWS uploads #2

Open
johnnyman727 opened this issue Feb 10, 2016 · 1 comment
Open

Permissions need to be set on AWS uploads #2

johnnyman727 opened this issue Feb 10, 2016 · 1 comment

Comments

@johnnyman727
Copy link
Contributor

Currently, after a new build and the builds.json has been uploaded, the permissions aren't set for everybody to view. We need the permission set this way to ensure everyone can download it.

@wyze
Copy link
Member

wyze commented May 9, 2016

I think this may be solved by adding the ACL property to this object here: lib/release.js#L293-L296

Looking here the ACL param looks like this:

  • ACL — (String) The canned ACL to apply to the object. Possible values include:
    • "private"
    • "public-read"
    • "public-read-write"
    • "authenticated-read"
    • "aws-exec-read"
    • "bucket-owner-read"
    • "bucket-owner-full-control"

So maybe setting ACL: 'public-read | bucket-owner-full-control' would set the correct permissions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants