Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky test CloseRelpFrameServerRXConsumerTest.testSendMessage #63

Open
kortemik opened this issue Feb 16, 2024 · 1 comment
Open

Comments

@kortemik
Copy link
Member

Description
CI reports

Error:    CloseRelpFrameServerRXConsumerTest.testSendMessage:130 expected: <true> but was: <false>

this is likely to be due to async closing of the FrameProcessorPool

@StrongestNumber9
Copy link
Contributor

I wasn't able to reproduce it locally without edits but it is 100% trigger rate with this edit

--- a/src/test/java/com/teragrep/rlp_03/CloseRelpFrameServerRXConsumerTest.java
+++ b/src/test/java/com/teragrep/rlp_03/CloseRelpFrameServerRXConsumerTest.java
@@ -80,6 +80,7 @@ public class CloseRelpFrameServerRXConsumerTest {
 
         @Override
         public void close() throws Exception {
+            Thread.sleep(1000);
             closed.set(true);
         }
     }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants