Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use descriptive test names instead of generic test_n #226

Open
StrongestNumber9 opened this issue Feb 8, 2024 · 1 comment
Open

Use descriptive test names instead of generic test_n #226

StrongestNumber9 opened this issue Feb 8, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@StrongestNumber9
Copy link
Contributor

Description

A test fails. It is called syslogStream_test_1. What does it do compared to syslogStream_test_2?

Use case or motivation behind the feature request

All tests should have descriptive names so you can know what it is testing just by looking at the name alone.
syslogStream_test_1 and syslogStream_test_2 should be called more like testSyslogStreamSending and testSyslogStreamSendingFailure

Related issues

@Test
@EnabledIfSystemProperty(named="runSparkTest", matches="true") // teragrep exec syslog stream
public void syslogStream_test_1() throws StreamingQueryException, InterruptedException, IOException {

@Test
@EnabledIfSystemProperty(named="runSparkTest", matches="true") // teragrep exec syslog stream, with preceding aggregation command
public void syslogStream_test_2() throws StreamingQueryException, InterruptedException, IOException {

Additional context

Haven't gone through most of the tests, this is just something I noticed when test got stuck and I went to check what it was supposed to be doing.

@StrongestNumber9 StrongestNumber9 added the enhancement New feature or request label Feb 8, 2024
@Abigael-JT Abigael-JT self-assigned this Oct 17, 2024
@Abigael-JT
Copy link
Contributor

Abigael-JT commented Oct 24, 2024

This was referenced Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants