Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11795: Implemented randomized FD tests to test the ring buffer #14014

Merged
merged 33 commits into from
Oct 28, 2024

Conversation

sagarwalTT
Copy link
Contributor

@sagarwalTT sagarwalTT commented Oct 18, 2024

Problem description

#11795
I've added tests that creates programs with several random conditions and then dispatches them in order to see how the ring buffer handles them.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)

@sagarwalTT sagarwalTT marked this pull request as ready for review October 23, 2024 17:34
@sagarwalTT sagarwalTT merged commit c5a8e58 into main Oct 28, 2024
8 checks passed
@sagarwalTT sagarwalTT deleted the sagarwal/ring_buffer_tests branch October 28, 2024 14:28
nemanjagrujic pushed a commit that referenced this pull request Oct 29, 2024
* #0: Initial changes

* #0: Moved some code to test_utils.hpp

* #0: More work on dispatcher test

* #0: More work on test implementation

* #0: Added support for runtime args

* #0: Moved kernel

* #0: Moved kernel

* #0: Removed new test file from CMakeLists.txt

* #0: Adding tests

* #0: More work on tests

* #0: Added more tests

* #0: Saving work

* #0: More work

* #0: Cleanup

* #0: Cleanup

* #0: Cleanup

* #0: More work

* #0: Removed file

* #0: Renamed tests

* #0: Use HalProgrammableCoreType

* #0: Fixed issue where no cores were being selected to dispatch to

* #0: Modified printing to be after every 10 iterations

* #0: Added CBs to the host

* #0: Fixed issue where min num rtargs is sometimes larger than the max num of rtargs

* #0: Finished implementing CBs

* #0: Cleanup

* #0: Implementing feedback

* #0: Use core_coord.hpp

* #0: Replaced TT_ASSERT with ASSERT

* #0: Added missing call to Finish()

* #0: Moved kernel parameters into struct

* #0: Modified kernel storage location

* #0: Prefixed with std::
ct-clmsn pushed a commit to ct-clmsn/tt-metal that referenced this pull request Nov 12, 2024
…uffer (tenstorrent#14014)

* #0: Initial changes

* #0: Moved some code to test_utils.hpp

* #0: More work on dispatcher test

* #0: More work on test implementation

* #0: Added support for runtime args

* #0: Moved kernel

* #0: Moved kernel

* #0: Removed new test file from CMakeLists.txt

* #0: Adding tests

* #0: More work on tests

* #0: Added more tests

* #0: Saving work

* #0: More work

* #0: Cleanup

* #0: Cleanup

* #0: Cleanup

* #0: More work

* #0: Removed file

* #0: Renamed tests

* #0: Use HalProgrammableCoreType

* #0: Fixed issue where no cores were being selected to dispatch to

* #0: Modified printing to be after every 10 iterations

* #0: Added CBs to the host

* #0: Fixed issue where min num rtargs is sometimes larger than the max num of rtargs

* #0: Finished implementing CBs

* #0: Cleanup

* #0: Implementing feedback

* #0: Use core_coord.hpp

* #0: Replaced TT_ASSERT with ASSERT

* #0: Added missing call to Finish()

* #0: Moved kernel parameters into struct

* #0: Modified kernel storage location

* #0: Prefixed with std::
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants