Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yolo v4 conv ops bringup #5079

Closed
dvartaniansTT opened this issue Feb 2, 2024 · 9 comments
Closed

yolo v4 conv ops bringup #5079

dvartaniansTT opened this issue Feb 2, 2024 · 9 comments

Comments

@dvartaniansTT
Copy link
Contributor

dvartaniansTT commented Feb 2, 2024

Describe the bug

  1. Some conv variants with groups=1 for yolov4 are failing. (12 failed, 113 passed) on resolution 480x640!

  2. Please note, we also need to add support for groups>1 for 46 of the convs in YOLOv4. (46 failed) add support for groups>1

Please prioritize enabling groups>1 as the failing groups==1 tests are passing on lower resolution 240x320! groups>1 separate issue: 6580
We eventually need to go as high as 960x 1280 resolution. But to expedite bringup process we can start with the lower-resolutions.

To Reproduce
from dvartanians/yolov4 run: pytest tests/ttnn/unit_tests/operations/test_conv2d.py::test_yolov4_conv

I also have a separate test for the groups > 1 convs for whenever we add support for it. you may run: pytest tests/ttnn/unit_tests/operations/test_conv2d.py::test_yolov4_conv_groups_larger_than_one

Expected behavior

  1. figure out the sharding configs or other parameters that would pass the failing conv tests for groups=1.
  2. figure out the optimal sharding configs that pass for the convs ideally we would like all convs to pass with block sharding or atleast minimal reshards in between the convs.
  3. add support for groups>1 convs.
  4. make all convs with groups>1 pass.
  5. make them pass with the most optimal configs.

Please complete the following environment information:

Additional context
customer feature!

@dvartaniansTT dvartaniansTT added bug Something isn't working ttnn op_cat: conv2D 2D convolution for CNNs labels Feb 2, 2024
@dvartaniansTT dvartaniansTT self-assigned this Feb 2, 2024
dvartaniansTT added a commit that referenced this issue Feb 5, 2024
dvartaniansTT added a commit that referenced this issue Feb 6, 2024
@jliangTT jliangTT added feature and removed bug Something isn't working labels Feb 7, 2024
dvartaniansTT added a commit that referenced this issue Feb 7, 2024
@dvartaniansTT dvartaniansTT changed the title yolo conv ops bringup yolo v4 conv ops bringup Mar 18, 2024
@dvartaniansTT dvartaniansTT added P1 and removed P2 labels Mar 18, 2024
@dvartaniansTT dvartaniansTT removed their assignment Mar 18, 2024
@jliangTT jliangTT added P2 and removed P1 labels Mar 18, 2024
@jliangTT
Copy link

Assigning to @nsmithtt to triage - putting this as p2 while we discuss the priority of these items offline.

@dvartaniansTT
Copy link
Contributor Author

I understand there are several asks in this one. I will make a separate issue for convs with groups > 1 and link it to this one.

@jliangTT
Copy link

jliangTT commented Apr 2, 2024

@nsmithtt , should this land in the conv generality bucket?

@mywoodstock
Copy link
Contributor

@dvartaniansTT are these still relevant? perhaps makes sense to try out with the latest conv version?

@saichandax
Copy link
Contributor

@mywoodstock , we'll look on this and let you know if this is still relevant. Some of the issues have been addressed as we already ported to new Conv API.
We will check the relevance and close in the next week.
Thanks.

@mywoodstock
Copy link
Contributor

@saichandax Any update on this one?

@mywoodstock
Copy link
Contributor

I believe this can be closed? @dvartaniansTT

@dvartaniansTT
Copy link
Contributor Author

@mywoodstock let me have a final check with MCW and will update here. thanks for your patience on this

@punithsekar
Copy link
Contributor

@dvartaniansTT, the version of yolov4 which we use reference, https://github.com/Tianxiaomo/pytorch-YOLOv4/blob/master/models.py, doesn't need group>1 need. Our input resolution of yolov4 was 320x320. For that resolution, the model works fine and we have merged it into the main. Once you acknowledge this comment we can close this issue Dalar.

CC: @saichandax

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in External Requests and Reports Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants