-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yolo v4 conv ops bringup #5079
Comments
Assigning to @nsmithtt to triage - putting this as p2 while we discuss the priority of these items offline. |
I understand there are several asks in this one. I will make a separate issue for convs with groups > 1 and link it to this one. |
@nsmithtt , should this land in the conv generality bucket? |
@dvartaniansTT are these still relevant? perhaps makes sense to try out with the latest conv version? |
@mywoodstock , we'll look on this and let you know if this is still relevant. Some of the issues have been addressed as we already ported to new Conv API. |
@saichandax Any update on this one? |
I believe this can be closed? @dvartaniansTT |
@mywoodstock let me have a final check with MCW and will update here. thanks for your patience on this |
@dvartaniansTT, the version of yolov4 which we use reference, https://github.com/Tianxiaomo/pytorch-YOLOv4/blob/master/models.py, doesn't need group>1 need. Our input resolution of yolov4 was 320x320. For that resolution, the model works fine and we have merged it into the main. Once you acknowledge this comment we can close this issue Dalar. CC: @saichandax |
Describe the bug
Some conv variants with groups=1 for yolov4 are failing. (12 failed, 113 passed) on resolution 480x640!
Please note, we also need to add support for groups>1 for 46 of the convs in YOLOv4. (46 failed) add support for groups>1
Please prioritize enabling groups>1 as the failing groups==1 tests are passing on lower resolution 240x320! groups>1 separate issue: 6580
We eventually need to go as high as 960x 1280 resolution. But to expedite bringup process we can start with the lower-resolutions.
To Reproduce
from dvartanians/yolov4 run:
pytest tests/ttnn/unit_tests/operations/test_conv2d.py::test_yolov4_conv
I also have a separate test for the groups > 1 convs for whenever we add support for it. you may run:
pytest tests/ttnn/unit_tests/operations/test_conv2d.py::test_yolov4_conv_groups_larger_than_one
Expected behavior
Please complete the following environment information:
Additional context
customer feature!
The text was updated successfully, but these errors were encountered: