-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttnn.ldexp_bw operation fails with low PCC #13929
Comments
@nemanjagrujic Do we need to checkout to specific branch to get the test file that mentioned in the description? I didn't find that in main |
@umadevimcw Checkout ngrujic/sweep-tests-1. I hope I will merge it soon. |
The problem is the range of input passed to the above op, ldexp depends on exp op. In the exp op, there is condition available to check whether input is > 89 and < -42. Please find the below image In the below you can find a simple python code where if the exp(89) is very large number and exp(-42) is too small number hence ttnn exp has such condition. Hence I have updated the range in the test and submitted the PR #14996 |
@umadevimcw Ok, just keep in mind that we need all relevant docs updated as well (exp, ldexp, ldexp_bw). |
### Ticket #13929 ### Problem description PCC for ldexp is 0.98 ### What's changed - Ldexp op depend on exp because of the when we go for larger range of input the pcc is dropped hence updated the ranges for the test - [Explanation](#13929 (comment)) - Updated the doc <img width="1180" alt="image" src="https://github.com/user-attachments/assets/3f1c9522-c4ca-4f4d-9ae1-50191dd8cf9e"> ### Checklist - [ ] [Post commit CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/11907115187) - [ ] [Sweep test](https://github.com/tenstorrent/tt-metal/actions/runs/11838333191)
Updated the document for ldexp and merged to main. Hence closing this issue |
ttnn.ldexp_bw operation fails with low PCC (eg 0.98)
Steps to reproduce
You can reproduce this error with sweep test
tests/sweep_framework/sweeps/eltwise/unary_backward/ldexp_bw.py
. To run:Results can be found on elastic cloud as explained here:
https://github.com/tenstorrent/tt-metal/tree/main/tests/sweep_framework
The text was updated successfully, but these errors were encountered: