From c5cfaa0c8b7b0809b33819c9166e4e22210b986c Mon Sep 17 00:00:00 2001 From: yugaoTT Date: Fri, 29 Nov 2024 14:00:19 +0000 Subject: [PATCH] #0: fixes --- tt_metal/hw/inc/blackhole/noc_nonblocking_api.h | 1 - tt_metal/hw/inc/wormhole/noc_nonblocking_api.h | 1 - .../dataflow/reader_bmm_tile_layout_in1_sender_dram_sharded.cpp | 2 ++ 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tt_metal/hw/inc/blackhole/noc_nonblocking_api.h b/tt_metal/hw/inc/blackhole/noc_nonblocking_api.h index a6155112bf69..d91e3dcc2708 100644 --- a/tt_metal/hw/inc/blackhole/noc_nonblocking_api.h +++ b/tt_metal/hw/inc/blackhole/noc_nonblocking_api.h @@ -554,7 +554,6 @@ inline __attribute__((always_inline)) void ncrisc_noc_fast_read_with_transaction NOC_CMD_BUF_WRITE_REG(noc, cmd_buf, NOC_RET_ADDR_LO, dest_addr); NOC_CMD_BUF_WRITE_REG(noc, cmd_buf, NOC_TARG_ADDR_LO, src_addr_); // (uint32_t)src_addr - NOC_CMD_BUF_WRITE_REG(noc, cmd_buf, NOC_PACKET_TAG, NOC_PACKET_TAG_TRANSACTION_ID(trid)); NOC_CMD_BUF_WRITE_REG(noc, cmd_buf, NOC_CMD_CTRL, NOC_CTRL_SEND_REQ); noc_reads_num_issued[noc] += 1; } diff --git a/tt_metal/hw/inc/wormhole/noc_nonblocking_api.h b/tt_metal/hw/inc/wormhole/noc_nonblocking_api.h index 75475665611a..08be1295cd42 100644 --- a/tt_metal/hw/inc/wormhole/noc_nonblocking_api.h +++ b/tt_metal/hw/inc/wormhole/noc_nonblocking_api.h @@ -451,7 +451,6 @@ inline __attribute__((always_inline)) void ncrisc_noc_fast_read_with_transaction NOC_CMD_BUF_WRITE_REG(noc, cmd_buf, NOC_RET_ADDR_LO, dest_addr); NOC_CMD_BUF_WRITE_REG(noc, cmd_buf, NOC_TARG_ADDR_LO, src_addr_); // (uint32_t)src_addr - NOC_CMD_BUF_WRITE_REG(noc, cmd_buf, NOC_PACKET_TAG, NOC_PACKET_TAG_TRANSACTION_ID(trid)); NOC_CMD_BUF_WRITE_REG(noc, cmd_buf, NOC_CMD_CTRL, NOC_CTRL_SEND_REQ); noc_reads_num_issued[noc] += 1; } diff --git a/ttnn/cpp/ttnn/operations/matmul/device/kernels/dataflow/reader_bmm_tile_layout_in1_sender_dram_sharded.cpp b/ttnn/cpp/ttnn/operations/matmul/device/kernels/dataflow/reader_bmm_tile_layout_in1_sender_dram_sharded.cpp index 0bbb1b239887..b6c6701e61a9 100644 --- a/ttnn/cpp/ttnn/operations/matmul/device/kernels/dataflow/reader_bmm_tile_layout_in1_sender_dram_sharded.cpp +++ b/ttnn/cpp/ttnn/operations/matmul/device/kernels/dataflow/reader_bmm_tile_layout_in1_sender_dram_sharded.cpp @@ -90,6 +90,8 @@ void kernel_main() { uint32_t l1_write_addr_in1_start = get_write_ptr(cb_id_in1); l1_write_addr_in1 = l1_write_addr_in1_start; for (uint32_t block = 0; block < num_blocks; ++block) { + noc_async_read_tile_dram_sharded_set_trid(curr_block_trid); + for (uint32_t h = 0; h < in1_num_pages; ++h) { noc_async_read_tile_dram_sharded_with_state_with_trid( in1_base_addr, l1_read_addr_in1, l1_write_addr_in1, curr_block_trid);