From 03647bd6ea4b688e5eabfc7e9b9b47eb87bd0098 Mon Sep 17 00:00:00 2001 From: avoraTT Date: Tue, 26 Nov 2024 04:49:13 -0800 Subject: [PATCH] Rebase and add tests for larger shapes. --- .../unit_testing/misc/test_matmul_1d_gather_in0.py | 10 +++++++++- ...ul_op_multi_core_reuse_mcast_1d_program_factory.cpp | 6 ------ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/tests/tt_eager/python_api_testing/unit_testing/misc/test_matmul_1d_gather_in0.py b/tests/tt_eager/python_api_testing/unit_testing/misc/test_matmul_1d_gather_in0.py index 8996f5c56b5..b5807061c54 100644 --- a/tests/tt_eager/python_api_testing/unit_testing/misc/test_matmul_1d_gather_in0.py +++ b/tests/tt_eager/python_api_testing/unit_testing/misc/test_matmul_1d_gather_in0.py @@ -103,8 +103,16 @@ def get_physical_to_logical_core_mapping(device): (3, 32, 2304, 3840, ttnn.bfloat16, ttnn.bfloat8_b, ttnn.MathFidelity.HiFi4, True, False, (8, 3)), # 32, 2304, 3840 (3, 32, 2304, 3840, ttnn.bfloat16, ttnn.bfloat8_b, ttnn.MathFidelity.HiFi4, False, True, (8, 3)), - # 256, 8192, 8192 + # 256, 1024, 8192 (1, 256, 1024, 8192, ttnn.bfloat16, ttnn.bfloat4_b, ttnn.MathFidelity.HiFi4, True, True, (8, 4)), + # 256, 1024, 8192 + (1, 256, 1024, 8192, ttnn.bfloat16, ttnn.bfloat4_b, ttnn.MathFidelity.HiFi4, True, True, (8, 4)), + # 128, 8192, 2048 + (1, 128, 8192, 2048, ttnn.bfloat8_b, ttnn.bfloat4_b, ttnn.MathFidelity.HiFi2, True, True, (8, 8)), + # 128, 8192, 2048 + (1, 128, 8192, 2048, ttnn.bfloat8_b, ttnn.bfloat4_b, ttnn.MathFidelity.HiFi2, True, False, (8, 8)), + # # 128, 8192, 2048 + # (1, 128, 8192, 2048, ttnn.bfloat8_b, ttnn.bfloat4_b, ttnn.MathFidelity.HiFi2, False, True, (8, 8)), # Fails with 0.98 PCC # 32, 64, 64 (1, 32, 64, 64, ttnn.bfloat16, ttnn.bfloat8_b, ttnn.MathFidelity.HiFi4, True, True, (2, 1)), # 32, 64, 64 diff --git a/ttnn/cpp/ttnn/operations/matmul/device/matmul_op_multi_core_reuse_mcast_1d_program_factory.cpp b/ttnn/cpp/ttnn/operations/matmul/device/matmul_op_multi_core_reuse_mcast_1d_program_factory.cpp index 0e1029b2fa9..8054a9eeb28 100644 --- a/ttnn/cpp/ttnn/operations/matmul/device/matmul_op_multi_core_reuse_mcast_1d_program_factory.cpp +++ b/ttnn/cpp/ttnn/operations/matmul/device/matmul_op_multi_core_reuse_mcast_1d_program_factory.cpp @@ -1680,9 +1680,6 @@ operation::ProgramWithCallbacks create_program_gather_in0( tt::DataFormat in0_data_format, tt::DataFormat in1_data_format, tt::DataFormat output_data_format, - bool in0_is_sharded, - bool in1_is_sharded, - bool output_is_sharded, bool untilize_out ) { @@ -2135,9 +2132,6 @@ operation::ProgramWithCallbacks matmul_multi_core_reuse_mcast_1d_optimized_( in0_data_format, in1_data_format, output_data_format, - a.memory_config().is_sharded(), - b.memory_config().is_sharded(), - output.memory_config().is_sharded(), untilize_out); }