Relax restrictions when inserting ttnn.to_layout and ttnn.{to,from}_device ops
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayerofieiev-tt
approved these changes
Oct 18, 2024
kevinwuTT
force-pushed
the
kw/layout_device_ops
branch
from
ea95934
to
7567f38
Compare
This was referenced Nov 1, 2024
… (with less fusion)
kevinwuTT
force-pushed
the
kw/layout_device_ops
branch
from
1751c98
to
6979151
Compare
kevinwuTT
force-pushed
the
kw/layout_device_ops
branch
from
02252cb
to
449f170
Compare
… it is the new generated node, not belong to any original input
This was referenced Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
None
Problem description
ttnn.reshapehas recently been updated to support more shapes. The compatibility workarounds that involved insertingttnn.to_layout,ttnn.to_device, andttnn.from_devicecan be relaxed. There are still a few issues still and they are tracked in the following bug reports:ttnn.reshapeoutput becomesROW_MAJORlayout but input wasTILElayout tt-metal#13891TODO:
ttnn.toandttnn.fromdevices to show differences from this PR