Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache option "Remember passphrase?" should be disabled when using WRAPPER backend #15

Open
robigan opened this issue Jun 12, 2024 · 3 comments
Assignees

Comments

@robigan
Copy link

robigan commented Jun 12, 2024

private refreshBackendSettings() {
if (this.settings.backend === Backend.WRAPPER) {
this.nativePublicKeySetting.settingEl.hide();
this.nativePrivateKeySetting.settingEl.hide();
this.executableSetting.settingEl.show();
this.trustModelSetting.settingEl.show();
this.compressionSetting.settingEl.show();
this.recipientSetting.settingEl.show();
this.checkGpgExecutable(this.settings.backendWrapper.executable);
this.refreshRecipientSetting();
} else {
this.nativePublicKeySetting.settingEl.show();
this.nativePrivateKeySetting.settingEl.show();
this.executableSetting.settingEl.hide();
this.trustModelSetting.settingEl.hide();
this.compressionSetting.settingEl.hide();
this.recipientSetting.settingEl.hide();
}
}

The option to cache the passphrase should be disabled when using a Wrapper implementation, regardless of if this project wishes to cache it or not, this should be handled by an agent and is generally WAY safer.

@robigan robigan changed the title Cache option "Remember passphrase? Cache option "Remember passphrase?" should be disabled when using WRAPPER backend Jun 12, 2024
@robigan
Copy link
Author

robigan commented Jun 12, 2024

I should say that the project can do whatever it wants, but I don't see code in main.ts for its usage when using wrapper backend. It's a pointless option when wrapper is used.

@tejado
Copy link
Owner

tejado commented Jun 12, 2024

Hey @robigan
With the current version you are correct: it has no function. But it was intentional as I wanted to add a symmetric encryption mode handled only over OpenPGP.js. I'm not sure yet if I will introduce this so it might make sense to disable it in the meantime for the gpg CLI wrapper.

@tejado tejado self-assigned this Jun 12, 2024
@robigan
Copy link
Author

robigan commented Jun 12, 2024

Hey @robigan With the current version you are correct: it has no function. But it was intentional as I wanted to add a symmetric encryption mode handled only over OpenPGP.js. I'm not sure yet if I will introduce this so it might make sense to disable it in the meantime for the gpg CLI wrapper.

Ahh I see what you mean. Why handled only by OpenPGP.js? Can't GPG do the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants