Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn about orphaned patches #385

Open
lengyijun opened this issue Oct 21, 2024 · 1 comment
Open

Warn about orphaned patches #385

lengyijun opened this issue Oct 21, 2024 · 1 comment
Labels
discussion The details of this issue have not been figured out yet. enhancement

Comments

@lengyijun
Copy link

In case official database updates
@niklasmohrin
Copy link
Collaborator

Do you mean that if you run tldr foo and there is no foo.md from tldr-pages, and no "foo.page.md" from you, we should still display foo.patch.md?

Given that patches are not written for display on their own (for example, they usually have no headline), I would refrain from doing so. However, we could include a note about the existence of a patch in the "page not found" message. What do you think?

@niklasmohrin niklasmohrin changed the title [feature request] Open patch.md if page.md not exists Display patch if no page exists Oct 21, 2024
@niklasmohrin niklasmohrin added enhancement discussion The details of this issue have not been figured out yet. labels Oct 21, 2024
@niklasmohrin niklasmohrin changed the title Display patch if no page exists Warn about orphaned patches Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion The details of this issue have not been figured out yet. enhancement
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lengyijun @niklasmohrin