Skip to content
This repository has been archived by the owner on Apr 20, 2022. It is now read-only.

mail.{{ domain }} confusion -> breaks mail_virtual_domains loops #38

Closed
taoeffect opened this issue Nov 22, 2014 · 3 comments
Closed

mail.{{ domain }} confusion -> breaks mail_virtual_domains loops #38

taoeffect opened this issue Nov 22, 2014 · 3 comments
Assignees
Labels

Comments

@taoeffect
Copy link
Owner

So mail_virtual_domains is often looped through in configuration files. In some places mail. is prepended and in some places it's not. For example, the recent PR #35 loops through this variable in openssl.cnf:

https://github.com/taoeffect/empress/pull/35/files#diff-fc4a7a00381d9bd47edfe77044dbca15R43

The user should be the one specifying what their mail server is called, and this should not be mutated by the scripts.

This screen illustrates the problem as well:

screen_shot_2014-11-22_at_12 12 31_pm

@taoeffect taoeffect added the bug label Nov 22, 2014
@taoeffect taoeffect self-assigned this Nov 22, 2014
@taoeffect
Copy link
Owner Author

A complete listing of all usages:

screen_shot_2014-11-22_at_12 19 54_pm

@taoeffect
Copy link
Owner Author

So one thing that's clearly broken is @PiPeep's PR #35 openssl.cnf: https://github.com/taoeffect/empress/pull/35/files#diff-fc4a7a00381d9bd47edfe77044dbca15R43

Which should contain the mail. prefix, or using the wildcard, or ignore it (but be explicit about that in a comment or something).

@taoeffect
Copy link
Owner Author

OK, @PiPeep switched to wildcards, and I think the rest of the usages of mail.{{ ... seem fine. The OpenDKIM stuff seems fine too. Apparently sent emails are signed as from default.EXAMPLE.com instead of mail.EXAMPLE.com... but our tests show that's OK.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant